Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 1.6.0 #117

Merged
merged 5 commits into from
Jun 9, 2020
Merged

chore: release 1.6.0 #117

merged 5 commits into from
Jun 9, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Jun 9, 2020 •
edited by pradn
Loading

1.6.0 (2020-06-09)

Features

  • Add flow control for message publishing (#96) (06085c4)

Bug Fixes

  • Fix PubSub incompatibility with api-core 1.17.0+ (#103) (c02060f)

Documentation

  • Clarify that Schedulers shouldn't be used with multiple SubscriberClients (#100) (cf9e87c)
  • Fix update subscription/snapshot/topic samples (#113) (e62c38b)

Internal / Testing Changes

  • Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) (#114) (0132a46)
  • Incorporate will_accept() checks into publish() (#108) (6c7677e)

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@plamut plamut requested a review from pradn June 9, 2020 22:27
plamut
plamut reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, where is #108?

Answer: The bot did not recognize the type of that PR and did not include it in the release notes, we will edit them manually.

Update: Actually, the bot only included 2 of the 6 commits added since the 1.5.0 release...

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
plamut
plamut suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update a few URLs...

CHANGELOG.md Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@plamut plamut mentioned this pull request Jun 9, 2020
Merged
4 tasks
@gcf-merge-on-green gcf-merge-on-green bot merged commit 60fe71a into master Jun 9, 2020
@yoshi-automation
Copy link
Contributor

Release is at https://github.com/googleapis/python-pubsub/releases/tag/v1.6.0

@busunkim96
Copy link
Contributor

@plamut The bot is configured to only add commits of type fix and feat to the changelog. If we want additional types, we can modify the logic.

@plamut
Copy link
Contributor

plamut commented Jun 10, 2020

@busunkim96 That would make sense, probably at least docs should be easy to classify.

Maybe adding a note / warning to the PR description would also be helpful to remind reviewers that CHANGELOG might not include all the commits and should be double-checked?

@failure-checker failure-checker bot mentioned this pull request Jun 10, 2020
Closed
This was referenced Jun 11, 2020
Closed
Closed
@failure-checker failure-checker bot mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. autorelease: tagged cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoshi-automation @busunkim96 @plamut @pradn @googlebot @yoshi-kokoro